hyperledger-labs / fabric-smart-client / 36541314790
92%

DEFAULT BRANCH: main
Ran
Jobs 22
Files 503
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.544% (+0.03%) from 86.516%
36541314790

push

github

web-flow 
fix(integration): stop asserting inside bare goroutines in container log helpers (#1922)

gomega.Expect calls inside a go func() have no Ginkgo recover() on their
stack, so a failed expectation panics past the goroutine and crashes the
whole test binary instead of failing one spec.

- startExplorerDB, startExplorer (hle/docker.go), startPrometheus, startGrafana
  (monitoring/docker.go): route their log-fetch goroutines through the
  existing docker.StartLogs helper, which already makes the fallible
  ContainerLogs call before spawning the goroutine, matching how
  otlp/docker.go already uses it.
- launchContainer (scv2/container.go): hoist the same ContainerLogs call
  above its goroutine instead of asserting inside it.
- startContainer (monitoring/docker.go): add defer ginkgo.GinkgoRecover()
  to the two WaitGroup-joined goroutines wrapping startPrometheus/
  startGrafana, since those do run for the spec's lifetime.

Fixes #1920

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

* test(integration): cover docker.StartLogs and document the goroutine/Gomega pitfall

StartLogs is now the log-streaming helper behind five call sites instead of
one, but had no unit coverage. Add tests for its two observable contracts:
a ContainerLogs error is returned synchronously (so callers can gomega.Expect
it outside any goroutine), and the background scanner closes the reader once
it reaches EOF.

Document when a Gomega assertion inside a spawned goroutine needs
GinkgoRecover versus must not be there at all, so this bug class doesn't
recur.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

27836 of 32164 relevant lines covered (86.54%)

2718.58 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
94.05
1.19% platform/view/services/comm/service.go
1
98.04
-1.96% platform/common/utils/cache/timeout.go
1
92.16
-0.21% platform/fabric/core/generic/committer/committer.go
1
87.5
-2.08% platform/fabric/events.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-atsachaincode - 36541314790.1 454
30.85
GitHub Action Run
2 utest-root - 36541314790.2 494
83.46
GitHub Action Run
3 itest-fabricx-iou - 36541314790.3 481
29.2
GitHub Action Run
4 itest-fabric-runtimeconfig - 36541314790.4 459
38.82
GitHub Action Run
5 itest-fabric-iouhsm - 36541314790.5 459
39.66
GitHub Action Run
6 itest-fabric-configupdate - 36541314790.6 459
38.77
GitHub Action Run
7 utest-extensions - 36541314790.7 8
52.57
GitHub Action Run
8 itest-fabric-stoprestart - 36541314790.8 449
31.22
GitHub Action Run
9 utest-postgres - 36541314790.9 494
9.73
GitHub Action Run
10 itest-fabric-events - 36541314790.10 454
29.02
GitHub Action Run
11 itest-fabric-iou-libp2p - 36541314790.11 459
36.56
GitHub Action Run
12 itest-fabric-iou - 36541314790.12 459
40.39
GitHub Action Run
13 itest-fabricx-deployment - 36541314790.13 481
28.37
GitHub Action Run
14 itest-fsc-signedpingpong - 36541314790.14 240
31.53
GitHub Action Run
15 itest-fabricx-configupdate - 36541314790.15 481
28.37
GitHub Action Run
16 itest-fsc-pingpong - 36541314790.16 245
34.62
GitHub Action Run
17 itest-fsc-stoprestart - 36541314790.17 241
33.43
GitHub Action Run
18 itest-fabric-twonets - 36541314790.18 449
29.22
GitHub Action Run
19 itest-fabric-atsa - 36541314790.19 449
43.73
GitHub Action Run
20 itest-fabricx-atsa - 36541314790.20 481
30.51
GitHub Action Run
21 itest-fabricx-simple - 36541314790.21 481
27.79
GitHub Action Run
22 itest-fabricx-multiendorsement - 36541314790.22 481
28.4
GitHub Action Run
Source Files on build 36541314790