DigitalTolk / ex / 36413183925

100%

push

github

Fix "Remind me" failing on DM messages (#270)

Setting a reminder on a message in a DM failed with "Couldn't set the
reminder". The date/time was never the problem (a datetime-local value is
locale-independent): the request itself was rejected.

Message.ParentType isn't persisted (dynamodbav:"-"); only live WebSocket
frames carry it. Messages loaded from the list API had none, so
MessageItem's reminder target fell back to parentType "channel" for a
conversation message, and the server's channel access check refused it
(403). Reproduced against a local stack: parentType "channel" → 403,
"conversation" → 201.

- Client: the reminder (and parent-watcher) target takes its parent type
  from the view the row renders in (channelId / conversationId), falling
  back to message.parentType only outside a view.
- Server: List, ListAfter, ListAround and ListThreadMessages (both the
  indexed and scan paths) stamp ParentType on every returned message, so
  every client — including already-shipped ones — gets it.

Co-authored-by: Habib Altaf <haltaf@zaraffasoft.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

8516 of 8516 branches covered (100.0%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 2 files covered. (100.0%)

39872 of 39878 relevant lines covered (99.98%)

2275.83 hits per line