DigitalTolk / ex / 36414428905

100%

push

github

Index shared agent users so they are findable in DM search (#274)

* Index shared agent users so they are findable in DM search

Agent users are created through the agent store (CreateAgentUser), never
through UserService, so nothing ever put them into the search index. On a
deployment with a search client that makes them unfindable: UserService.Search
delegates to the indexer and hydrates only the ids it returns, so an agent
never appears in the DM composer's recipient lookup and cannot be DM'd at all.

It worked locally only because a deployment without a search client falls
through to a linear scan over ListUsers, which reads the canonical rows and so
never needed the index.

Indexing runs on every boot rather than only on first create. Agents seeded
before this shipped already exist, so CreateAgentUser returns ErrAlreadyExists
and the row would otherwise stay unindexed forever, with no repair short of a
manual reindex. Re-indexing an unchanged row is idempotent.

The stored record is indexed, not the struct just constructed, so an admin
rename is not silently reverted by the next restart.

* test fix

8516 of 8516 branches covered (100.0%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

39884 of 39890 relevant lines covered (99.98%)

2280.43 hits per line