moonbitlang / core / 6892

89%

push

github

style: write scalar literals as T(x) instead of (x : T) (#4331)

Extends the Float(x) cleanup to the other scalar types with an identity
constructor (T::T(self : T) -> T = "%identity"): Int16, Int64, UInt,
UInt16, UInt64, Byte, Int and Double. As with Float, the constructor's
parameter type makes the literal a T directly, exactly like the
annotation, so this is a pure spelling change.

322 numeric- and char-literal annotations in 27 files, plus one
redundant annotation on an already-suffixed literal ((0U : UInt) -> 0U)
dropped outright. Parameter lists
are untouched, and so is the literal form (1 : Json), since Json(x) goes
through ToJson.

Exception: inside builtin's own library and whitebox sources, the
constructor syntax does not resolve for Byte, UInt, UInt16 and UInt64
("value identifier UInt16 is unbound"), though it does for Int16, Int64,
Double and Float and for all of them from other packages. Those four
keep the annotation there; builtin's doc tests and blackbox tests, which
compile as a separate package, use the constructor.

No .mbti change and no snapshot change on any target.

Codex review (2 rounds): round 1 found the skipped (0U : UInt); round 2
approved.

Signed-off-by: Codex CLI <codex@openai.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

12 of 16 new or added lines in 7 files covered. (75.0%)

16673 of 18643 relevant lines covered (89.43%)

333308.82 hits per line