eclipse-aascw / aas-core-codegen / 36337843067

90%

Build Type

push

github

Committed by web-flow

Commit Message

Declare mutability of verification parameters (#781)

We let the verification functions declare which arguments they mutate,
and check the bodies against the declarations in all the targets. A
``List[T]`` argument is mutable, a ``Sequence[T]`` one read-only, and
an object argument is read-only unless declared ``Mutable["Item"]``.
Mutability is deep, flows from the root variable to the values reached
through it, and is fixed at a variable's definition; an invariant's
``self`` and method results are read-only. ``Sequence`` and ``Mutable``
are refused anywhere but on the arguments of verification functions,
*e.g.*, on properties, and ``Mutable`` around a list or a primitive
value is refused with an explanation.

Python shares a stored list, while C++ copies it, so a stored list must
be an explicit copy in all the targets:

    item.texts = texts[:]

C++ now supports the assignments to the properties and the list items.
A ``List`` argument becomes ``std::vector<T>&``, the targets use
setters and ``mutable_x()`` getters, and a new aliasing analysis
declares each local as a copy, ``const auto&`` or ``auto&`` so that it
behaves as in Python, or reports an error where neither is faithful.
This also removes needless copies, *e.g.*,
``const auto& texts = item->texts();``.

The ``assignment_targets`` meta-model now covers the mutations across
calls, loops and aliases. Since only C++ copies the lists by value, we
remove the generated unit tests of the other targets, which share them
as Python does, and generate the unit tests executing the mutations
only for C++.

Coverage Stats

614 of 671 new or added lines in 21 files covered. (91.51%)

14 existing lines in 2 files now uncovered.

40875 of 46211 relevant lines covered (88.45%)

2.65 hits per line