PHPOffice / PHPPresentation / 36328974545

94%

push

github

ODPresentation Writer and Reader : Write the decorative flag in the graphic style of a shape (#1024)

* ODPresentation Writer and Reader : Write the decorative flag in the graphic style of a shape

The Writer put loext:decorative on the shape element. Impress reads it from
the graphic properties of the shape's style only (xmloff sdpropls.cxx), and
ODF 1.4 standardizes it there as draw:decorative, so a decorative shape came
out of LibreOffice as a figure without alternative text. The flag now goes
into the style a text box, a picture, a media and a line already wear; a
decorative table, chart or group, which wear no graphic style, gets one that
says only that. A shape that is not decorative is written as before.

Measured with LibreOffice 26.8 and master: the decorative picture, line,
chart, text box, table and group are no longer in the structure tree of the
tagged PDF, and the page renders the same.

The Reader takes the flag from the style, under either name, and falls back
on either attribute on the shape, which this Writer used to write.

* Changelog : Link #1024

20 of 20 new or added lines in 2 files covered. (100.0%)

11609 of 12299 relevant lines covered (94.39%)

81.28 hits per line