hyperledger-labs / fabric-smart-client / 36316333925

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric,fabricx): report a missing endorsement or response instead of dereferencing it (#1901)

driver.ProposalResponse wraps a peer.ProposalResponse received from a
counterparty before its signature is verified. Endorsement and Response
are optional protobuf fields, so a syntactically valid message can omit
either one and still unmarshal successfully, leaving the field nil.

Both the classic-Fabric and fabricx implementations of ProposalResponse
dereferenced Endorsement and Response directly in Endorser,
EndorserSignature, ResponseStatus, ResponseMessage, and
VerifyEndorsement, so a peer could crash the process handling the
response by omitting either field. The endorser view calls Endorser()
on every response before VerifyEndorsement runs, so the panic is
reachable before the response's signature is checked. Transaction's
recordProposalResponse compares the same fields directly while
deduplicating incoming endorsements, so it panics the same way.

Read every field through the generated Get*() accessors, which already
return the zero value on a nil receiver. This matches how the rest of
each package already treats these messages, for example ledger.go and
queryservice/query.go on the fabricx side.

Add tests covering the accessors, VerifyEndorsement, and
recordProposalResponse/AppendProposalResponse with a nil Endorsement on
either side of the comparison, for both platforms.

Fixes #1899

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

14 of 14 new or added lines in 4 files covered. (100.0%)

11 existing lines in 5 files now uncovered.

27763 of 32103 relevant lines covered (86.48%)

2299.6 hits per line