eclipse-aascw / aas-core-codegen / 36307766311

90%

push

github

Transpile member and index assignment targets (#779)

We support the assignments to a property (``obj.p = v``) and to a list
item (``xs[i] = v``) in the verification functions. Previously, C#,
Java, Go and C++ crashed on an assert, and TypeScript generated
``AasCommon.at(xs, i) = v``, which does not compile.

The type inference refuses the other targets with a message specific
to the kind of target, *e.g.*, tuple items, JSON-able values,
enumeration literals and methods.

The targets follow the Python semantics:

* C# assigns directly (``item.Texts[^1] = text;``).
* Java uses setters and ``List.set``, and passes ``null`` for empty
  optionals (``item.setMaybeText(other.getMaybeText().orElse(null));``).
* Go uses setters, and copies a non-optional value into a pointer
  with the new ``aascommon.NewAndPointTo``. It replaces ``NewBool``,
  ``NewInt``, ``NewInt64``, ``NewFloat64`` and ``NewString``, which
  breaks the clients calling them.
* TypeScript uses the new ``AasCommon.setAt``, which resolves negative
  indices and throws on an index out of range instead of growing
  the array.
* C++ reports that the assignment is not supported yet, since its
  vectors are copied by value.

We test the semantics with the new common meta-model
``assignment_targets.py`` and generated unit tests which call its
verification functions in all the SDKs except C++.

219 of 243 new or added lines in 22 files covered. (90.12%)

40392 of 45675 relevant lines covered (88.43%)

2.65 hits per line