coreui / coreui-pro / 36227286435

95%

main: 94%

push

github

test(TimePicker, DateRangePicker): pin the popup lifecycle events (#1440)

* test(TimePicker, DateRangePicker): pin the popup lifecycle events

The show/shown/hide/hidden events and the .show class come from PickerBase, and only the DatePicker spec checked them, through DatePicker's own override of the toggle attributes. TimePicker and DateRangePicker document the same events under their own namespaces with nothing checking them. Both specs now carry the three DatePicker cases: the events fire in order around an indicator click with .show and aria-expanded following, a prevented show keeps the picker closed, and a prevented hide keeps it open. The DatePicker cases gain the two checks the new ones make: aria-expanded goes back to false, and .show stays while a hide is prevented.

Removing .show from the element, ignoring a prevented show or a prevented hide, or leaving aria-expanded at true in PickerBase now fails each of the three specs.

* test(DateRangePicker): cover the disabled picker like the date picker does

The date picker's show/hide block also checks that a disabled picker disables its indicator and refuses to open; the date range picker had neither case. Ignoring the disabled check in PickerBase.show now fails the date range picker spec too.

6116 of 6675 branches covered (91.63%)

Branch coverage included in aggregate %.

11209 of 11529 relevant lines covered (97.22%)

736.88 hits per line