moonbitlang / core / 6817

89%

push

github

perf(debug, json): format inspect locations only when the check fails

`debug_inspect` and `json_inspect` converted `loc` and `args_loc` to
JSON strings on every call, although they are only used in the
`@EXPECT_FAILED` message of a failing check. Builtin `inspect` already
formats them lazily. Move the formatting into the failure branch.
The failure message is unchanged (new tests check it still carries the
locations).

These run in almost every test in the repository, so a passing check
is the hot path. Release benchmarks, main -> this:

| bench                          | native          | js              | wasm-gc         |
|--------------------------------|-----------------|-----------------|-----------------|
| debug_inspect(42) passing      | 1.29us -> 175ns | 1.33us -> 42ns  | 1.68us -> 68ns  |
| debug_inspect([1..5]) passing  | 2.91 -> 1.73us  | 2.13us -> 838ns | 2.45us -> 862ns |
| json_inspect(42) passing       | 1.30us -> 175ns | 1.29us -> 22ns  | 1.69us -> 74ns  |

Codex review: "Approved; behavior identical, message text byte-identical (follow-up: json failure test now asserts expect/actual)."

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

4 of 4 new or added lines in 2 files covered. (100.0%)

16497 of 18388 relevant lines covered (89.72%)

313978.09 hits per line