moonbitlang / core / 6792

89%

push

github

refactor(random, splitmix): add Rand() and RandomState() constructors

Core has moved type construction to `T(...)` (StringBuilder, Hasher,
Buffer, Ref, argparse, the collections), but the two random number
generators went in opposite directions and neither had a constructor:
`@splitmix` deprecated the method `RandomState::new` in favour of a
free `new`, while `@random` deprecated its free `new` in favour of the
method `Rand::new`.

- `Rand::Rand(generator?)` replaces `Rand::new`, which stays as a
  deprecated alias. `Rand::chacha8(seed?)` remains the named
  constructor for a seeded generator. `Rand` was a tuple struct whose
  constructor reserved the name, so its field is now named (`source`);
  the type is abstract, so the interface is otherwise unchanged.
- `RandomState::RandomState(seed?)` replaces the free
  `@splitmix.new`, which stays callable as a deprecated free function;
  the deprecated `RandomState::new` now points at `RandomState()`.

Migrate in-repo callers.

Part of #4272.

Codex review: "No blocking issues found. Constructor behavior, seed defaults, deprecated aliases, call-site migrations, and documentation are consistent."

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

7 of 7 new or added lines in 5 files covered. (100.0%)

16498 of 18390 relevant lines covered (89.71%)

314699.83 hits per line