umputun / tg-spam / 36033562144

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(config): keep CLI-supplied credentials out of dashboard saves (#456)

* fix(config): keep CLI-supplied credentials out of dashboard saves

In --confdb mode applyCLIOverrides lays --telegram.token,
--openai.token, --gemini.token, --jev.token and --server.auth /
--server.auth-hash over the values loaded from the database. Saving
from the settings UI (POST /config, PUT /config?saveToDb=true) then
wrote the whole in-memory settings back, so a credential the operator
only passed through the environment ended up in the config row, in
plaintext unless --confdb-encrypt-key is set, and in the backup the
dashboard offers for download. After that, dropping the flag no longer
removed it, because the database now held it.

applyCLIOverrides records every credential it takes from the command
line in Transient.CredentialsFromCLI. Store.Save writes the value the
database already holds for those fields (or nothing when there is no
row yet), and loadConfigHandler keeps their in-memory values across a
reload, as it already does for an AuthFromCLI hash. save-config clears
the list, since storing command-line values is its purpose. The
auto-generated password from the no-auth fallback is not recorded and
is persisted by a UI save as before.

* docs(config): say rotation needs save-config --confdb, fix reload godoc

Plain save-config builds the whole config from CLI flags and replaces
everything set in the web UI, so the docs now send rotation of a stored
credential to save-config --confdb with the same --db, --instance-id and
--confdb-encrypt-key, and keep plain save-config for seeding a fresh
database. db-conf.md notes that a credential an earlier dashboard save
already wrote stays in the config row and older backups. The
ReloadNormalize godoc no longer says DB rotation wins on reload, and
each auth flag alone now has a case in the CLI override test.

Coverage Stats

54 of 56 new or added lines in 4 files covered. (96.43%)

6 existing lines in 2 files now uncovered.

9470 of 11173 relevant lines covered (84.76%)

234.85 hits per line