umputun / tg-spam / 36033546857

84%

push

github

fix(events): never ban the group or its linked channel (#457)

* fix(events): never ban the group or its linked channel

Telegram accepts BanChatSenderChat for the channel linked to a
discussion group. An admin /spam or /ban in reply to a linked channel
post, a forward of such a post to the admin chat, or a /warn auto-ban
therefore banned the channel from its own discussion group, and
aggressive cleanup deleted the recent channel posts there. Posts by
anonymous admins were already exempt; the linked channel now is too.

The /report check for channel and anonymous admin posts tested
From == nil, but in groups the Bot API sets From to the Channel_Bot or
GroupAnonymousBot placeholder, so such reports went through and named
the placeholder as the reported user. SenderChat now decides.

* fix(events): report a skipped ban in the admin chat, document report rule

The admin chat message for /spam, /ban and admin-chat forwards was built
before the own-chat check, so it said the user was banned when the post
came from the group itself or its linked channel and the ban was
skipped. The check now runs first and the message says the ban was
skipped. README notes that users can't report posts made on behalf of a
channel or by an anonymous admin.

29 of 29 new or added lines in 3 files covered. (100.0%)

9434 of 11131 relevant lines covered (84.75%)

232.22 hits per line