umputun / tg-spam / 36160447164

84%

push

github

fix(events): accept user reports only from the monitored group (#462)

* fix(events): accept user reports only from the monitored group

The user-report dispatch ran before the chat filter in procEvents, and
DirectUserReport always acts on the monitored group. A reply /report (or
report, spam, /spam) sent in any other chat the bot is a member of
deleted the command by its message ID in the monitored group, hitting an
unrelated message with the same ID, and an approved reporter's report was
stored with the monitored group's chat ID and the other chat's message
and user, so the threshold ban and the admin ban button acted on them
there.

The dispatch now requires the monitored group, the same check #455
applied to anonymous admins. A report from another chat falls through to
procEvents, which drops it, or spam-checks it as an ordinary message in a
testing chat.

Fixed #459

* fix(events): drop foreign-chat report commands, delete testing-chat spam in its chat

A report command replying in a testing chat fell through to the spam
check, which appends the reported text to the command. The reporter
could be banned for the spam he reported when he was unapproved or the
bot ran with first-message-only off. Non-superuser report commands sent
as replies outside the monitored group are now dropped before the
user-report dispatch, regardless of whether reporting is enabled or the
sender posts as a channel.

Spam detected in a testing chat was banned there but deleted by its
message ID in the monitored group, so the spam stayed and an unrelated
message with the same ID could be deleted. The delete now targets the
chat the message came from.

Related to #459

6 of 6 new or added lines in 1 file covered. (100.0%)

9477 of 11178 relevant lines covered (84.78%)

240.08 hits per line