kobotoolbox / kpi / 36012895504

83%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(attachments): restore attachments retired by mistake DEV-2804 (#7596)

### 📣 Summary

Support can now bring back, project by project, the files that
disappeared from a submission moments after being uploaded.

### 📖 Description

A file could vanish from its submission right after being sent, with no
error and a success returned to the client. It happened whenever the
name stored with the file did not match the name written in the
submission, which several separate bugs could cause: a name sanitised on
the way in, an accented name stored in one unicode form and written in
another, or a question renamed between two versions of the form. Each of
those was fixed in turn, but none brought back the files already lost.

This adds a way to recover them for one project at a time, on request
rather than in bulk, so that a project can be inspected before anything
is written and the outcome can be checked against what its owner
expects. Restored files return to the data table, attached to their
question, with their storage back in the owner's quota.

### 👷 Description for instance maintainers

Two ways in, both doing the same work on a single project.

A management command, for a shell on the instance:

```
./manage.py restore_soft_deleted_attachments --asset-uid aBcD1234
./manage.py restore_soft_deleted_attachments --asset-uid aBcD1234 --no-dry-run
./manage.py restore_soft_deleted_attachments --asset-uid aBcD1234 --no-dry-run --email you@example.org
```

It reports without writing anything unless `--no-dry-run` is passed.
`--email` mails the log once the run is over, whether it succeeded or
not, and can be repeated for several recipients. `--no-resume` ignores
where an interrupted run stopped.

And Django admin, for support with no shell access, under a new
**Support tools** section: **Attachment restores**
(`/admin/support_tools/attachmentrestorejob/`). Adding a row is what
launches a run. Fill the project in, leave *Dry run* ticked to see what
would come ... (continued)

Coverage Stats

10289 of 13641 branches covered (75.43%)

258 of 344 new or added lines in 7 files covered. (75.0%)

1 existing line in 1 file now uncovered.

32929 of 39718 relevant lines covered (82.91%)

5.5 hits per line