kobotoolbox / kpi / 35854913355

83%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(library): transfer uploaded library items to the organization and let admins delete them DEV-2873 (#7622)

### 📣 Summary
Library items uploaded by a member of a Teams organization now belong to
the organization, and organization admins can delete library items from
My Library.

### 📖 Description
In a Teams organization, whatever a member creates belongs to the
organization. That was already true for question blocks, templates and
collections created from the Library. Items added with the Upload button
were the exception: they stayed with the person who uploaded them. They
now go to the organization as well, and the uploader can still edit and
manage them.

Admins were also missing the Delete option on library items owned by
their organization, although they are allowed to delete them. The option
is now there, as it is for projects.

### 💭 Notes
- `ImportTask` used to create assets with the requesting user as owner.
It now does what the API create path does (`perform_create_override` and
`AssetSerializer.create`): owner from `get_real_owner`,
`is_excluded_from_projects_list`, `manage_asset` for the uploader on
every created item in the same transaction (collections only pass view
and change down to their children), plus `created_by` and
`last_modified_by`. We need `created_by` because the non-owner delete
rule checks it, so without it a plain member could not delete their own
upload anymore. Imports into an existing asset are not touched.
- The API already let admins delete, the block was in the frontend.
`AssetMoreActions` showed Delete only with `delete_submissions`, which
library assets can never have, so in practice only the owner saw it. It
now uses the same condition as `projectQuickActions`. The backend still
has the last word, so Delete on an asset from outside the org ends in
the usual error.
- `owner__username` in the import messages now gives the asset's owner
instead of the uploader.
- Dropping an XLSForm on the project list runs the sa... (continued)

Coverage Stats

10201 of 13539 branches covered (75.35%)

5 of 39 new or added lines in 2 files covered. (12.82%)

439 existing lines in 20 files now uncovered.

32627 of 39391 relevant lines covered (82.83%)

5.51 hits per line