IJHack / QtPass / 35990547109

93%

Build Type

push

github

Committed by web-flow

Commit Message

MainWindow: the delete question and the Share menu are their own functions (#1917)

* MainWindow: the delete question and the Share menu are their own functions

onDelete() decided four things at once — what is selected, whether it is a
folder, whether that folder is a link, and what the question should say about
stray files — and showContextMenu() built four menus inline. Both read as
what they do now: onDelete() resolves the target and asks (confirmDeletion()
or confirmLinkRemoval()), showContextMenu() adds the folder actions from a
small table and hands the Share submenu to addShareMenu().

cx 23 -> 6 for onDelete, 16 -> 8 for showContextMenu; the two CodeFactor
findings left in src/ after the previous pass. No behaviour change: the same
questions, the same entries in the same order, enabled by the same rules, as
the main-window suite pins them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* The delete question is whole sentences, not pieces

The prompt was built as "Are you sure you want to delete %1%2?" with %2
either "?" or " and the whole content?", so it read "delete /foo??" for an
entry and ended "...</strong>?" for a folder with stray files. And it cannot
be translated: a verb-final language has to put the rest of the question
after the path, and the translators for ja, ko, hi, tr, ta, te, fa, et, lb,
nl, pa, ur and si had resorted to "...: %1%2"; Greek could not get its ";".

Three strings instead: one question for an entry, one for a folder, and the
stray-file warning as a sentence of its own. "before continue" is
"before continuing" while the string is new anyway.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* lupdate + best-effort translations for the delete questions

The two new delete questions, the stray-file warning, and "%1 could not be
re-encrypted: %2" from #1908, ... (continued)

Coverage Stats

78 of 79 new or added lines in 1 file covered. (98.73%)

41 existing lines in 2 files now uncovered.

8797 of 9466 relevant lines covered (92.93%)

151.51 hits per line