coreui / coreui-pro / 35887881462

95%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(DatePicker): share the field format helpers and drop dead date utilities (#1397)

DatePicker and DateRangePicker carried the same `_resolveFormat`,
SectionInput repeated the body of `getDateSections`, and DateInput built
its default date or date-time layout by hand. The format lookup moves to
`getPickerFormat` and the layout to `getSectionLayout` in
`util/date-sections`, the names the React and Vue date inputs use, and
all four callers go through them. `getSectionLayout` takes an
`includeTime` flag shaped like React's (`true` or `{ seconds }`), which
DateInput and DatePicker's hour cycle lookup pass. An empty `format`
still counts as none, as before; a spec now pins that, and another pins
that a timepicker with no mask takes the locale's hour cycle (ko-KR and
en-CA are 12-hour in Intl while `isAmPm` reads them as 24-hour).
`SectionFormat` is now the one type of the `format` option.

Removed exports that nothing in the library imports: all of
`util/date-range-picker.ts`, `getFirstAvailableDateInRange`,
`getSelectableDates`, `createDateFromMonth` and `createDateFromWeek` from
`util/calendar`, and `convertTimeToDate`, `getAmPm` and `isValidTime`
from `util/time`. `createDateFromYear`, `formatTimePartials` and
`shouldUseTwoDigitHour` stay but are no longer exported; their specs now
go through `convertToDateObject` and `getLocalizedTimePartials`.
`formatTimePartials` labels from a fixed date rather than today, so a
zone whose DST starts at midnight no longer labels hour 0 as "01" on that
day. The package exports every file under `js/dist`, so the migration
guide lists the helpers a deep import could have reached.

Coverage Stats

6001 of 6619 branches covered (90.66%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 7 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

11102 of 11487 relevant lines covered (96.65%)

597.92 hits per line