coreui / coreui-pro / 35885328005

95%

main: 94%

push

github

fix(DatePicker): declare the options the pickers read (#1396)

DatePicker read `format`, `monthNames` and `selectionType`, and
DateRangePicker `format` and `selectionType`, without declaring them in
`Default`, `DefaultType` or the config type. The picker's own type check
never saw them, so `format: 42` passed the picker and failed later inside
DateInput or DateRangeInput, under a component name the caller never
constructed. Both pickers now declare them and the check runs where the
option was given. Like every other declared option, they no longer accept
an explicit `undefined`.

The defaults (`null`, `null`, `'day'`) keep what the code did without
them: `_forwardConfig` passes on only values that differ from the
picker's default, the mask falls back to the locale for `'day'`, and
`convertToDateObject` parses a day string for `'day'` and `undefined`
alike. The config types reuse `SectionInputConfig['format']` and
`['monthNames']`.

The options tables list the new options, and DatePicker's lists
`floatingLabel`, which it declared but the table left out.

6025 of 6655 branches covered (90.53%)

Branch coverage included in aggregate %.

11143 of 11533 relevant lines covered (96.62%)

593.24 hits per line