solidjs / solid / 35798385589

74%

main: 89%

push

github

fix(ssr): contain post-render and bare-child async rejections in renderToString/renderToStream (#3570, #3569) (#3594)

* fix(solid): observe the server async deferred so a post-render rejection cannot exit the process (#3570)

Every server async flight (memo, store, projection, async generator)
settles an internal deferred from `createDeferredPromise`, and
`settleServerAsync` settles it unconditionally so a serialized flight
lands whatever the node's lifetime. Under `renderToString` there is no
serialization channel (`ctx.async` is unset) and the sync `<Loading>`
path never awaits the NotReadyError's source; a `<NoHydration>` zone or
an unread source has no consumer either. A rejection landing after the
HTML was returned therefore rejected a promise with zero subscribers —
an `unhandledRejection` that took Node down with exit code 1, and no
`<Errored>` could see it because the render was over.

Observe the deferred at creation. Real subscribers still see the
rejection exactly as before (a no-op rejection arm is a separate derived
promise). The other internal promises on the path (`subscribePendingRetry`,
the user promise's `.then(v, e)`, the abandoned duplicate flight, the
iterator close) were already observed.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

* fix(ssr): a rejecting direct child of <Loading> no longer hangs or crashes renderToStream (#3569)

Two independent layers, each verified on its own.

Routing (solid-js, `ssrLoadingBoundary.runDiscovery`): a template hole
that throws is routed through `ssrHandleError` to the boundary's own
ErrorContext handler, which — once the fragment is registered — owns the
error: `<key>_fr` rejects and the client re-renders the subtree
(`handling: "client"`, the #2997 verdict). A bare child
(`<Loading>{data()}</Loading>`, or a component whose return IS the read)
threw straight out of `fn()` and bypassed that handler, so
`finalizeError` saw an uncontained error and, pre-flush, failed the whole
reques... (continued)

555 of 824 branches covered (67.35%)

Branch coverage included in aggregate %.

827 of 1073 relevant lines covered (77.07%)

17.56 hits per line