solidjs / solid / 35800446262

74%

main: 89%

push

github

test(web): run the performance-tracks spec on a controllable engine clock (#3598)

The spec's colour and duration assertions were cut against wall-clock
`performance.now()` deltas the attribution engine stamps on its records —
a wave is `primary` under 16ms, a callback `secondary-light` under 10ms,
a hold `error` from `longHolds.infoMs` — so a loaded CI runner crossed a
threshold at random (#3594: a two-run drain read `>= 16ms` and the wave
came out `primary-dark`).

Every test now runs on a `performance.now()` of its own, frozen unless the
test advances it inside a compute, a callback, a handler, or while a flight
is in the air. Every span's start/end, every record's `handlerMs`,
`settledMs`, `totalMs`, `holdMs`, `tailMs`, `durationMs` and `shownMs`, and
every `Duration`/`Settled`/`Held`/`Self time` property is asserted exactly
against the advances made; the `>=`/`toBeCloseTo`/`- 0.001` tolerances and
the real `setTimeout(10)` waits are gone. Each threshold — the wave's 16ms,
the callback's 10ms/100ms, the self-time palette's 0.5/10/100ms, and the
engine's long-hold verdict at 500ms — is exercised on both sides, at its
exact boundary value.

No source change: the engine's `now()` reads `performance.now()` on every
call and the adapter paints only from the records, so a stand-in on
`performance.now` (installed and torn down like the spec's other
`performance` stand-ins) is the whole hook.

Co-authored-by: Claude via Cursor <noreply@cursor.com>

555 of 824 branches covered (67.35%)

Branch coverage included in aggregate %.

827 of 1073 relevant lines covered (77.07%)

17.58 hits per line