coreui / coreui-pro / 35776950460

95%

main: 94%

push

github

refactor(DatePicker)!: fold the date time picker into a timepicker option, and restore the v5 time UI (#1388)

* refactor(pickers)!: one time rendering per picker, selects back in the date time picker

v5 embedded the time picker through DateRangePicker._getTimePickerConfig(), which
hard-coded type: 'inline' and variant: 'select', so no date picker ever showed a
roll. v6 gave both pickers a variant option defaulting to 'roll', and the date
time picker rendered scrolling columns where v5 rendered selects.

Each picker now has one rendering: the time picker shows the roll, the date time
picker shows the selects. The variant option is gone from both, pinned in the
call to the shared selection primitive rather than dropped from Default alone --
_forwardConfig passes a key through by name, so a config that still carried
variant would have reached the primitive. selectionOptions stays as the
documented escape hatch.

The select rules follow their only consumer: .time-picker-inline-select and its
five tokens move to _date-picker.scss, which stops using time-picker entirely.
The embedded body also stops declaring all 19 time picker tokens to read 6.

Same build both sides:

  date-picker.css  3307 B -> 3258 B, no longer requires time-picker
  time-picker.css  4693 B -> 3606 B
  coreui.css     696862 B -> 695372 B

A page with a plain date picker or a date time picker drops from 8000 B to
3258 B of picker CSS; a standalone time picker from 4693 B to 3606 B.

Measured in Chromium: the date time picker renders 4 selects and 0 roll columns,
the time picker 0 and 4. Against the full stylesheet, the per-component sheets
differ on 0 of 137438 properties for the time picker, and on the same 7
pre-existing --cui-btn-* properties the calendar already shows on v6-dev for the
other two.

* fix(DateTimePicker): put the time row back under the calendars, with its clock icon

v5 laid the popup out as a grid -- "ranges calendars" over "ranges timepickers" --
so the time row ... (continued)

5934 of 6549 branches covered (90.61%)

Branch coverage included in aggregate %.

240 of 251 new or added lines in 5 files covered. (95.62%)

11063 of 11447 relevant lines covered (96.65%)

587.54 hits per line