IJHack / QtPass / 35766482329

93%

Build Type

push

github

Committed by web-flow

Commit Message

Only a comparison of two known identities proves a swap (#1908)

* Only a comparison of two known identities proves a swap

From the adversarial review of #1906.

On FAT and exFAT the file ID is the offset of the directory entry, which a
rename moves whenever the new name needs a different number of entries: every
staged write on a store on a USB stick would have been reported as swapped.
Those filesystems have no hard links either — the swap the check identifies
needs one — so the file is taken as it is found there, and generally the write
now stands wherever the system cannot give both identities. On 32-bit builds
that was also fstat() failing with EOVERFLOW for an inode number that does not
fit a 32-bit struct stat, so unix builds define _FILE_OFFSET_BITS=64.

The reason a ciphertext could not be placed names the scratch file gpg wrote
when it comes from the copy; the summary line names the entry as well, as the
list promises.

The systematic-failures test restores the store's permissions before any
failure return, so a failing run does not leave an unremovable directory
behind, and the replaceFile test accepts a filesystem that refuses a hard link
to a symlink (HFS+ ENOTSUP, Linux protected_hardlinks) as long as it leaves no
name behind. Docs: placeEncryptedFile() and recoverReencryptLeftovers() say
what the code does now, and an entry that could not be replaced keeps its old
ciphertext rather than being "left as it was".

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* tests: check the summary's detail lines, not its heading

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

10 of 12 new or added lines in 2 files covered. (83.33%)

3 existing lines in 1 file now uncovered.

8803 of 9469 relevant lines covered (92.97%)

149.61 hits per line