IJHack / QtPass / 35766441897

93%

Build Type

push

github

Committed by web-flow

Commit Message

Hide the password dialog before it is destroyed; a reload forgets what was typed (#1907)

* Hide the dialog before it is destroyed; a reload forgets what was typed

From the adversarial review of this branch.

The destructor disconnected the line edits, which left the other way into a
slot of the destroyed dialog open: FieldLabel's rename editor commits through
editingFinished() -> finishEdit() -> renamed() -> renameField(), and ASAN
shows the use-after-free when a shown dialog with an open editor is deleted.
The destructor hides the dialog instead, while the object is whole, so every
focus-out slot runs on it and QDialog's own hide is a no-op.

setPassword() reuses the template line edits and refills them, so the mark
that says "the user typed in this field" had to go with the old value: a
second decrypt landing for the same entry (the tree view issues one, the
dialog another) otherwise turned a loaded backup code into an otpauth URI.

validateOtpField() and normalizeOtpField() act on the line hookOtpField()
wired up rather than re-resolving otpLineEdit(): the signals that reach them
are that line's, and which field is the OTP one is settled when the fields
change, not by what the user types into them.

Three tests (each red on the previous commit, the reload one also under the
mutation that drops the mark reset), and the rename in the first test is now
committed by leaving the editor: Return also reaches the dialog's default
button, which accepted the dialog and left the rest of that test running on a
hidden, already-saved one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* tests: wait for the row before editing its name

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

8792 of 9457 relevant lines covered (92.97%)

149.62 hits per line