elixir-mint / mint / f79a60a7f7bdfbe6a1863318d4d3c1787fc138a2-PR-508

89%

main: 91%

Build Type

Pull #508

github

Committed by ericmj

Commit Message

Apply the HTTP/2 header table size to the decoding table as a limit

HPAX.resize/2 sets the table's own maximum size along with the maximum
the protocol permits. For the decoding table that maximum belongs to the
server's encoder, which declares it with a dynamic table size update
(RFC 7541 4.2), so raising SETTINGS_HEADER_TABLE_SIZE also raised it and
kept entries the server had evicted. An indexed reference to one of them
decoded to a stale header instead of failing with a compression error.

HPAX.protocol_resize/2 changes only the permitted maximum and follows it
down when it drops below what the encoder declared. After a reduction
the server has to declare its new size at the start of the next field
block, which RFC 9113 4.3.1 requires the client to enforce, so a block
that doesn't is now a connection error with COMPRESSION_ERROR.

Pull Request Pull Request #508: DO NOT MERGE: Apply the HTTP/2 header table size to the decoding table as a limit

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

37 existing lines in 1 file now uncovered.

1520 of 1718 relevant lines covered (88.47%)

552.18 hits per line