IJHack / QtPass / 35473502079

93%

Build Type

push

github

Committed by web-flow

Commit Message

ProfileInit writes .gpg-id whole or not at all; the store boundary is a path boundary (#1857)

* ProfileInit writes .gpg-id whole or not at all; the store boundary is a path boundary

ProfileInit::writeGpgId() still opened .gpg-id with QFile and wrote into
it, so an interrupted first run could leave a truncated recipient list for
the signing step, or a later start without signing, to take as the
profile's recipients. It uses the same QSaveFile sequence as
ImitatePass::writeGpgIdFile() now: temporary in the same folder,
owner-only before commit, byte count checked, renamed into place.

Pass::getGpgIdPath() decided "inside the store" with a plain
startsWith(passStore), the textual-prefix mistake #1844 removed from
RealPass::Init: with a store given without a trailing separator,
"/store-other/x" counted as inside "/store". The walk up to the store's
.gpg-id had a proper boundary check, so nothing wrong was returned, but the
weaker test is gone and the loop shares the one boundary.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* getGpgIdPath: compare paths the way the platform's file system does

On Windows a store configured as C:/Store and a file reported under
c:/store are the same place; a case-sensitive boundary check would miss a
nested .gpg-id there and fall back to the root one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

19 of 19 new or added lines in 2 files covered. (100.0%)

9 existing lines in 1 file now uncovered.

6926 of 8862 relevant lines covered (78.15%)

74.9 hits per line