IJHack / QtPass / 35472238879

93%

Build Type

push

github

Committed by web-flow

Commit Message

Key generation: no passphrase only when asked for (#1852)

* Key generation: no passphrase only when asked for

The default batch template carries %no-protection and the dialog's OK was
enabled as soon as the two passphrase fields agreed, empty included, so a
new user who skipped the fields got a private key stored unprotected
without anything saying so. For a password manager whose whole model rests
on the GPG key being protected separately from the store, that is the
wrong default.

OK now needs a passphrase typed twice the same, or the new "No passphrase:
store the private key unprotected" checkbox. Ticking it clears and
disables the fields, so a passphrase typed earlier cannot be sent along by
accident; unticking asks for one again. applyPassphrase() is unchanged:
an empty passphrase still yields %no-protection, it just has to be chosen.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Key generation: after a failed attempt OK follows the passphrase rule, not a blind re-enable

generationFailed() switched the button box back on unconditionally, which
would have handed out OK with empty fields and no waiver had done() been
reached some other way than the button. Recompute instead; regression
test drives done() directly and expects OK to stay off.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Key generation: done(Accepted) holds the passphrase rule itself

CodeRabbit on #1852: the disabled button is one gate; done() is reachable
otherwise (a default button, a script), so it checks passphraseChosen()
and returns without starting anything. Silent: the disabled OK already
says what is missing. The generation tests tick the waiver to get past
it; two tests drive done() without a choice and expect nothing to start.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https:/... (continued)

Coverage Stats

23 of 23 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

6917 of 8854 relevant lines covered (78.12%)

74.89 hits per line