coreui / coreui-pro / 35404781073

94%

main: 94%

push

github

fix(MultiSelect): honour pickerIcon false (#1368)

The button was built unconditionally, so `pickerIcon: false` left a
focusable control announced as "Toggle options list" whose visible text
was the literal string "false", since the option value was written into
the button as its content. React and Vue already skip the button, and
the v6 migration guide says `pickerIcon: false` hides it here too.

`_createButtons()` now clears `_indicatorElement` before it decides
whether to build one. Without that, a rebuild through `setConfig` left
the field pointing at the button in the discarded wrapper, and the
selection cleaner, which is inserted before it, went into the detached
tree and never appeared again.

The cleaner also falls back to appending to the toggler when no button
exists.

The docs table never listed `pickerIcon` for this component, though
Autocomplete documents the same option. The row says the button toggles
the list, because the control itself only opens it.

5762 of 6375 branches covered (90.38%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

10971 of 11361 relevant lines covered (96.57%)

531.66 hits per line