open-quantum-safe / liboqs / 35354665037
80%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2452
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.359% (-0.002%) from 80.361%
35354665037

push

github

web-flow 
Fix AND separator in ARM64 required_flags CMake guard (#2567)

The Jinja loop that emits the ARM64_V8 instruction-flag guard in
add_enable_by_alg_conditional.fragment used

    {%- if not loop.last or loop.first %} AND {% endif -%}

which places the separator *before* the first flag and omits it before
the last. With a single required flag the two mistakes cancel out and
the output is the harmless duplicate

    OQS_USE_ARM_NEON_INSTRUCTIONS AND OQS_USE_ARM_NEON_INSTRUCTIONS

but with two or more flags the last two tokens are concatenated:

    OQS_USE_ARM_NEON_INSTRUCTIONS AND OQS_USE_ARM_NEON_INSTRUCTIONSOQS_USE_ARM_SHA3_INSTRUCTIONS

CMake treats the concatenated name as an undefined variable, which is
false, so the whole conjunction is false and the NEON implementation can
only ever be enabled via OQS_DIST_ARM64_V8_BUILD -- never through
OQS_USE_ARM_NEON_INSTRUCTIONS/OQS_USE_ARM_SHA3_INSTRUCTIONS.

Emit " AND " before every flag instead. The leading
OQS_USE_ARM_NEON_INSTRUCTIONS is already written out by the template, so
this renders identically for single-flag platforms (all 44 existing
lines are byte-for-byte unchanged) and correctly for two or more.

Regenerate .CMake/alg_support.cmake: 18 lines, all mqom neon guards, the
only platform in-tree with two ARM required_flags (asimd + sha3).

Signed-off-by: Eva Crystal <0xiviel@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

176255 of 219335 relevant lines covered (80.36%)

3582388.32 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
95.55
 -0.35% src/sig/falcon/pqclean_falcon-512_clean/keygen.c
3
96.25
 -0.26% src/sig/falcon/pqclean_falcon-1024_clean/keygen.c
2
76.11
 -1.77% src/kem/hqc/pqc-hqc_hqc-3_ref/vector.c
2
75.22
 -1.77% src/kem/hqc/pqc-hqc_hqc-5_ref/vector.c
2
83.81
 -0.57% src/sig/mayo/pqmayo_mayo-1_neon/mayo.c
2
64.9
 -0.46% src/sig/ml_dsa/mldsa-native_ml-dsa-65_x86_64/mldsa/src/sign.c
1
98.36
 0.0% src/kem/classic_mceliece/pqclean_mceliece460896_clean/encrypt.c
1
97.96
 -2.04% src/kem/classic_mceliece/pqclean_mceliece460896f_avx2/encrypt.c
1
95.73
 -0.09% src/sig/falcon/pqclean_falcon-padded-512_aarch64/keygen.c
1
95.53
 -0.09% src/sig/falcon/pqclean_falcon-padded-512_avx2/keygen.c
1
96.15
 -3.85% src/sig/mayo/pqmayo_mayo-1_neon/arithmetic.c
1
96.49
 0.0% src/sig/ml_dsa/mldsa-native_ml-dsa-44_aarch64/mldsa/src/packing.c
1
96.49
 -1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-87_aarch64/mldsa/src/packing.c
1
64.98
 -0.23% src/sig/ml_dsa/mldsa-native_ml-dsa-87_aarch64/mldsa/src/sign.c
1
94.74
 0.0% src/sig/ml_dsa/mldsa-native_ml-dsa-87_x86_64/mldsa/src/packing.c
Jobs
ID Job ID Ran Files Coverage
1 arm64-distbuild - 35354665037.1 1495
57.74
 GitHub Action Run
2 x64-generic - 35354665037.2 1073
82.69
 GitHub Action Run
3 x64-distbuild - 35354665037.3 2027
54.17
 GitHub Action Run
Source Files on build 35354665037