open-quantum-safe / liboqs / 35233847903
80%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 2452
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.361% (-0.005%) from 80.366%
35233847903

push

github

web-flow 
build(cmake): allow CMAKE_POSITION_INDEPENDENT_CODE to be overridden (#2524)

* build(cmake): allow CMAKE_POSITION_INDEPENDENT_CODE to be overridden

CMakeLists.txt hardcoded `set(CMAKE_POSITION_INDEPENDENT_CODE ON)`. Because
that creates a normal variable, it shadows the cache entry for the rest of the
directory scope, so both `-DCMAKE_POSITION_INDEPENDENT_CODE=OFF` and a
toolchain file setting it were silently discarded and `-fPIC` was still passed
to every source file.

Set it only when the consumer has not chosen a value, so static and embedded
targets that provide no GOT/PLT can opt out.

liboqs is assembled from OBJECT libraries, which do not inherit the implicit
position independent code setting of the shared `oqs` target, so honouring OFF
for a shared build would link a shared library from non-PIC objects. That
combination is therefore refused with a warning instead.

Defaults are unchanged: every configuration that was possible before produces
an identical set of compile commands.

Fixes #1882

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: maximilliangrand <214999687+maximilliangrand@users.noreply.github.com>

* option() is cleaner than if(DEFINED ...)

Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Assisted-By: chatgpt:gpt-6-astra-medium

---------

Signed-off-by: maximilliangrand <214999687+maximilliangrand@users.noreply.github.com>
Signed-off-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>
Co-authored-by: maximilliangrand <214999687+maximilliangrand@users.noreply.github.com>
Assisted-by: claude:opus-5
Co-authored-by: Ganyu (Bruce) Xu <g66xu@uwaterloo.ca>

176260 of 219335 relevant lines covered (80.36%)

3585288.14 hits per line

Coverage Regressions

Lines Coverage ∆ File
20
70.59
 -29.41% src/kem/ml_kem/mlkem-native_ml-kem-768_x86_64/mlkem/src/sampling.c
5
88.89
 -7.94% src/kem/ml_kem/mlkem-native_ml-kem-768_ref/mlkem/src/sampling.c
3
96.25
 -0.26% src/sig/falcon/pqclean_falcon-padded-1024_clean/keygen.c
2
94.74
 -1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-87_x86_64/mldsa/src/packing.c
1
95.92
 -2.04% src/kem/classic_mceliece/pqclean_mceliece460896_avx2/encrypt.c
1
97.3
 -1.35% src/kem/classic_mceliece/pqclean_mceliece460896_clean/pk_gen.c
1
76.99
 0.88% src/kem/hqc/pqc-hqc_hqc-5_ref/vector.c
1
95.64
 -0.09% src/sig/falcon/pqclean_falcon-padded-512_clean/keygen.c
1
76.7
 -0.49% src/sig/falcon/pqclean_falcon-padded-512_clean/vrfy.c
1
96.49
 0.0% src/sig/ml_dsa/mldsa-native_ml-dsa-44_aarch64/mldsa/src/packing.c
1
94.74
 -1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-44_ref/mldsa/src/packing.c
1
96.49
 -1.75% src/sig/ml_dsa/mldsa-native_ml-dsa-87_ref/mldsa/src/packing.c
1
96.3
 -1.85% src/sig/uov/pqov_ov_Is_avx2/ov.c
Jobs
ID Job ID Ran Files Coverage
1 arm64-distbuild - 35233847903.1 1495
57.74
 GitHub Action Run
2 x64-generic - 35233847903.2 1073
82.69
 GitHub Action Run
3 x64-distbuild - 35233847903.3 2027
54.17
 GitHub Action Run
Source Files on build 35233847903