ruby-grape / grape / 35331562996

99%

master: 99%

Pull #2954

github

Answer a DELETE whose body holds invalid bytes instead of raising

A DELETE that sets no status answers 204 when its body is blank, and
default_status asks with ActiveSupport's String#blank?, which matches a
regexp. Matching a regexp against a String whose bytes are not valid in its
encoding raises ArgumentError, so such a body crashed the request before
the formatter ever saw it.

It takes little to get one. Path params are tagged UTF-8 without being
checked, so `delete(':name') { "deleted #{params[:name]}" }` hands a
request for `/caf%C3%A` a String holding half a character; reading a
binary file with the default external encoding does the same.

A String like that is never blank -- an invalid byte is not whitespace --
so default_status now says so before asking blank?, and the DELETE answers
200 with its body, as it does for any other.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1429 of 1483 branches covered (96.36%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

4266 of 4266 relevant lines covered (100.0%)

28549.11 hits per line