ruby-grape / grape / 35330680770

99%

push

github

Route a splat path the same way however many routes a method has (#2952)

Pattern#build_path_from_pattern makes the '/' ahead of a trailing `*path`
optional, so `files/*path` matches `/filesextra` as well as `/files/extra`.
RouteBuckets still took `files` as the key that route sits under, so a
request for `/filesextra` looked up the bucket for `filesextra`, found none,
and was matched against the fallback, which does not hold the splat route.

The answer then depended on how many routes the method had. Below eight
routes there are no buckets and the full union served `/filesextra` with
`path` set to `extra`; from eight on the same request was a 404, while a
POST to it answered 405 with an Allow header offering GET, and OPTIONS
listed GET too.

The segment ahead of a trailing `*path` is now left unkeyed, the way the
last segment of an unanchored route already was: both are segments a path
can run on from without a '/', and a route there sits in every bucket.

Checked against 4.0.1, which predates the buckets, on 1.25M requests
generated from random route tables (many sibling resources, splats,
requirements, path and header versioning, mounts, anchors), including paths
that glue a segment onto the next: no response differs.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1427 of 1481 branches covered (96.35%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

4263 of 4263 relevant lines covered (100.0%)

28575.68 hits per line