IJHack / QtPass / 35204585977

93%

push

github

One resolution rule for external binaries (#1800)

* One resolution rule for external binaries

Executor::execute() rewrote every non-absolute executable to
<applicationDirPath>/<name> at enqueue time while executeBlocking() handed
the name to QProcess, i.e. a PATH lookup: the same configured
gpgExecutable could run two different binaries, and a bare "gpg" typed
into the settings failed for every queued command unless QtPass shipped
its own copy.

Executor::resolveExecutable() is now applied in startProcess(), which both
paths use: absolute paths and "wsl ..." as given, a bare or relative name
taken from next to the application when a file (or file.exe) exists
there, otherwise left to PATH. Tests cover the bare-name case on both
paths, the bundled-copy precedence and the rule table; the first two
fail with the previous logic.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* resolveExecutable: executable files only, .exe candidate on Windows only, cleaned paths

Plus tests: a plain data file next to the application must not mask PATH,
the rule table runs on every platform, and Windows checks the .exe fallback.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Clean the application-directory candidate paths in tst_executor

Both bundled-binary tests now normalise the path next to the test binary
with QDir::cleanPath(), matching what Executor::resolveExecutable()
returns, so the Windows expectation no longer needs to clean it again.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

10 of 10 new or added lines in 1 file covered. (100.0%)

5816 of 7714 relevant lines covered (75.4%)

72.61 hits per line