IJHack / QtPass / 35201519242

93%

Build Type

push

github

Committed by web-flow

Commit Message

Typed Profile struct instead of QHash<QString, QHash<QString, QString>> (#1799)

* Typed Profile struct instead of QHash<QString, QHash<QString, QString>>

The nested hash was spelled out 22 times, its keys were string literals
and the Git flags a hand-parsed ""/"true"/"false" tri-state in three
places. Profile {path, signingKey, std::optional<bool> useGit/autoPush/
autoPull} and Profiles = QMap<QString, Profile> replace it; the
tri-state lives in Profile::flagFromString/flagToString and unset means
"follow the global setting". On-disk keys are unchanged.

The six getProfile*/setProfile* accessors on QtPassSettings had no
production caller and are gone; their test became a Profile round trip
covering all three states.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* profile.h: document the comparison operators for doxygen

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* profile.h: document the fields

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

47 of 87 new or added lines in 4 files covered. (54.02%)

1 existing line in 1 file now uncovered.

5777 of 7707 relevant lines covered (74.96%)

68.26 hits per line