IJHack / QtPass / 35198163954

93%

Build Type

push

github

Committed by web-flow

Commit Message

KeygenDialog drives key generation itself; ConfigDialog no longer knows MainWindow (#1796)

* KeygenDialog drives key generation itself; ConfigDialog no longer knows MainWindow

The result of gpg --gen-key travelled KeygenDialog -> ConfigDialog::genKey
-> MainWindow::generateKeyPair (a QPointer kept only to relay) ->
generateGPGKeyPair signal -> QtPass lambda -> Pass::GenerateGPGKeys, and
back via QtPass::onKeyGenerationComplete -> MainWindow::cleanKeygenDialog
-> close() -> reject(). So a successful keygen made checkSecretKeys()'s
exec() return Rejected and the first-run wizard gave up; the QPointer
existed because of a use-after-free (#1603) on that path.

KeygenDialog takes the Pass, connects to finishedGenerateGPGKeys and
processErrorExit for the duration of one run, accepts on success and on
failure shows the reason and re-enables the form. The relay members,
signal and lambda are gone; ConfigDialog takes a plain QWidget parent and
drops mainwindow.h.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* KeygenDialog listens to a keygen-specific failure signal; cancel test keeps the dialog alive

Pass::processErrorExit fires for any command that fails while gpg is
generating (a queued git push, say) and would have taken the dialog down
mid-run. Pass now also emits generateGPGKeysFailed(err) for GPG_GENKEYS
and the no-gpg case; the dialog connects to that. The cancel test emits
the late signals at a still-living dialog so the explicit disconnects are
what is being tested.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* KeygenDialog: a retry restarts the progress indicator

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

41 of 46 new or added lines in 4 files covered. (89.13%)

39 existing lines in 2 files now uncovered.

5790 of 7770 relevant lines covered (74.52%)

65.98 hits per line