chartjs / chartjs-plugin-zoom / 35190097117

89%

push

github

fix: give the plugin geometry its own non-nullable Point (#970)

Chart.js 4.5 widened Point to `{ x: number | null; y: number | null }` so it
can also describe a gap in a dataset. The plugin used that same type for
canvas geometry, so bumping the dev dependency to 4.5.1 (#962) fails to
compile with 15 errors across core, gestures, handlers, scale.types and utils.

Every one of those is a zoom centre, a drag corner, a pan delta or a hit test
position -- a real coordinate that is never null. Rather than null check values
that cannot be null, Point is now declared in src/types.ts and the geometry
imports it from there. Chart.js keeps being imported for everything else.

This also tightens the public API in the right direction: passing a Chart.js
Point, which may now hold nulls, into chart.zoomRect() or chart.pan() no
longer type checks, and it would have misbehaved at runtime.

Compiles and passes the browser tests against both 4.4.8 and 4.5.1, so #962
should go green once it is rebased on this.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

316 of 401 branches covered (78.8%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 3 files covered. (100.0%)

814 of 870 relevant lines covered (93.56%)

1373.65 hits per line