IJHack / QtPass / 35163176172

93%

Build Type

push

github

Committed by web-flow

Commit Message

A menu bar (#1787)

* A menu bar

The toolbar was icon-only, non-movable and had its context menu disabled,
so Push, Pull, Users and Config existed nowhere but as icons, and there was
no About or FAQ at all. mainwindow.ui now declares a QMenuBar — File,
Store, Settings, Help — over the same QActions (enabled state stays in
step for free) plus four menu-only actions: Quit (Ctrl+Q, QuitRole), FAQ
(F1, opens the rendered FAQ.md on qtpass.org), About QtPass (AboutRole)
and About Qt (AboutQtRole). actionConfig gets PreferencesRole and Ctrl+,,
so macOS builds its application menu.

Ctrl+Q used to be a bare QShortcut that only closed the window; it is the
Quit action now and quits, like the tray menu's Quit and Cmd+Q.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Menu Quit goes through close(), so "hide on close" still applies

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Menu: Quit quits, Close window (Ctrl+W) is the configurable one

Ctrl+Q/Cmd+Q quits the application in KeePassXC, Telegram and per the
KDE, GNOME and macOS guidelines, tray icon or not; "hide on close" governs
closing the window. So Quit is wired to QApplication::quit and a new
File > Close window (Ctrl+W) does what the old Ctrl+Q shortcut did:
close(), which hides for tray users.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* CHANGELOG: the Ctrl+Q change is its own entry

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Menu bar only: Quit keeps the old Ctrl+Q behaviour

No semantics change in this PR. Quit is wired to close(), which "hide on
close" turns into a hide, exactly what the bare Ctrl+Q shortcut did. The
Close-window action and the quit-vs-close decision ... (continued)

Coverage Stats

4 of 14 new or added lines in 1 file covered. (28.57%)

29 existing lines in 2 files now uncovered.

5575 of 7726 relevant lines covered (72.16%)

61.29 hits per line