hyperledger-labs / fabric-smart-client / 35100979561

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: replace fmt.Errorf and stdlib errors.New with pkg/utils/errors (#1860)

Production code had drifted from the documented convention of building and
wrapping errors exclusively through pkg/utils/errors: 127 fmt.Errorf call
sites across 44 files and 14 stdlib errors.New call sites across 9 files.
Test files are left untouched since their sentinel/mock errors are ordinary
Go testing idiom, not a convention violation.

fmt.Errorf(...%w..., err) becomes errors.Wrapf(err, ...) (or errors.Wrap
when no other args remain); other fmt.Errorf calls become errors.Errorf or
errors.New; stdlib errors.New becomes our errors.New. Files that still need
stdlib errors.Is/As/Unwrap keep it under a stderrors alias so our package
can be imported unaliased as errors.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

28 of 65 new or added lines in 28 files covered. (43.08%)

10 existing lines in 5 files now uncovered.

27385 of 31960 relevant lines covered (85.69%)

2356.98 hits per line