hyperledger-labs / fabric-smart-client / 35025109872

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor!: propagate errors instead of panicking (#1845)

utils.Must/utils.MustGet turn an error into a panic. Four call sites on the
node-startup / store-construction path panicked despite every enclosing
function already returning error and already propagating sibling errors
normally: newKVS, GetPersistenceName, and the two GetTableNames functions.
They now return the error instead of crashing the process.

Also fixes escapeForTableName's bare panic on the same call path: Fabric
channel names legally contain digits, but escapeForTableName validated
against ^[a-zA-Z_]+$, so a channel named e.g. mychannel1 panicked at vault
store construction instead of surfacing the existing wrapped error at
channelprovider.go.

Wrap errors.Wrapf around the entry points that would otherwise lose context
on propagation (GetPersistenceName, Format, both GetTableNames), add godoc
to the constructors and helpers on this call path, and replace the
remaining utils.MustGet calls in sqlite tests and benchmarks with testify
require / plain error propagation.

BREAKING CHANGE: (*TableNameCreator).MustGetTableName is removed from
platform/view/services/storage/db; call CreateTableName and handle the
error instead. Table-name and persistence-name construction on the store
startup path (GetPersistenceName, GetTableNames, and escapeForTableName's
callers) no longer panics on invalid config or channel names; callers that
relied on that fail-fast crash now receive a normal error return.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

79 of 131 new or added lines in 18 files covered. (60.31%)

6 existing lines in 4 files now uncovered.

27339 of 31949 relevant lines covered (85.57%)

2345.17 hits per line