hyperledger-labs / fabric-smart-client / 35025060767

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor!: propagate TLS config errors instead of panicking in websocket host (#1846)

Config.ClientTLSConfig/ServerTLSConfig panicked via utils.MustGet on an
invalid root CA pool or keypair, even though every caller (NewHost, the
endpoint-based provider) already returns error and could propagate it
instead of crashing the process on bad configuration.

NewHost and GetNewHost now propagate that error instead of calling
utils.MustGet themselves, and NewConfigFromProperties (a test helper) moved
from config.go to websocket_test_utils.go and returns (*config, error)
instead of *config, for the same reason.

Every changed function gets a regression test that actually triggers its
error branch (invalid root CA PEM, unreadable key/cert files) rather than
just the happy path, so a dropped error check or wrong wrap message would
be caught.

BREAKING CHANGE: websocket.Config.ClientTLSConfig and ServerTLSConfig now
return (*tls.Config, error) instead of *tls.Config. websocket.NewHost now
returns (*host, error) instead of *host. NewConfigFromProperties moved from
config.go to websocket_test_utils.go and now returns (*config, error)
instead of *config.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

32 of 36 new or added lines in 3 files covered. (88.89%)

8 existing lines in 3 files now uncovered.

27306 of 31860 relevant lines covered (85.71%)

2771.12 hits per line