solidjs / solid / 34997410529

74%

main: 89%

push

github

fix(signals): a Loading `on` reset collects what its forwarded readers still wait on (#3459) (#3467)

* fix(signals): a Loading `on` reset collects what its forwarded readers still wait on (#3459)

The `on` reset cleared the boundary's sources and rebuilt them from the
pending notifications that followed. A reader already pending from an
earlier write never re-notifies (status propagation dedupes on its
`_pendingSources`), so with `fast` and `slow` read from sibling effects
only the fresh flight was collected; the wake committed the held write
(#3375: a reader behind a collecting boundary holds nothing), `fast`
landed a microtask later, and the boundary revealed `B: 1 | Fast: 1 |
Slow: 0` with `slow` still in the air.

The reset now harvests, from every live transaction's `_asyncReporters`
(INV-3, the one record of a forwarded reader), the sources of each
reporter it routes (`_holds`: under this queue with no collecting
pending-type boundary between, the `reporterBlocksSource` test) plus that
reporter's `_pendingSources`, and flips to the fallback when it found
any. The hold the ruling takes off the lane lands on the boundary:
`B: 1 | Loading`, then `Fast: 1 | Slow: 1` together. `scheduler.ts`
exports `transitions` for the walk; no scheduling logic changes.

Core floor unchanged (23,752). Docs bullet, rules index, changeset.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* chore(size): hydrating+stores cap 28.85 -> 28.90 KB — #3459's reset walk on top of #3464/#3465/#3466

Measured at 28861 B against next's 28815 (+46). The PR alone sat 2 B
under against the pre-#3464 next; the three fixes that landed meanwhile
used the room.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* docs(signals): regenerate rules index after the INTERNALS merge resolution

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Brenley Dueck <brenleydueck@Brenleys-Mac-mini.local>
Co-auth... (continued)

520 of 790 branches covered (65.82%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.08 hits per line