solidjs / solid / 34993407918

74%

main: 89%

push

github

fix(signals): isPending() inside a memo reports a hold whose staged node is unstamped (#3457) (#3465)

A memo wrapping isPending(copy) cached false for a whole hold while a
direct isPending(copy) render-effect probe read true. `slow` pended first
and opened the transaction; `copy` then staged its value straight into the
transaction's batch, unstamped until the flush stashed the hold. The
wrapper memo, recomputing on the companion flip, read copy's fresh staged
value, and heldAwaitingAsync's reporter scan was gated on the missing
`_transition` stamp, so the A10 fresh-read pairing rule muted the verdict
even though the transaction's async source was still computing.

Run the reporter scan for an unstamped node too: with a transaction
active, the ambient batch IS that transaction, so the node's staged write
belongs to the transaction `t` resolved to. The pairing rule still stands
for a landed answer awaiting reveal, and the #3078 action carve-out is
untouched. Spec note under A10; rules index regenerated; changeset.

Co-authored-by: Brenley Dueck <brenleydueck@Brenleys-Mac-mini.local>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Ryan Carniato <ryansolid@gmail.com>

520 of 790 branches covered (65.82%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.09 hits per line