• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 34984905743
86%

Build:
DEFAULT BRANCH: main
Ran 15 Sep 2026 02:58PM UTC
Jobs 1
Files 274
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Sep 2026 02:55PM UTC coverage: 85.823% (+0.2%) from 85.654%
34984905743

push

github

web-flow
Record the RPC outcome on telemetry activities (#4943)

Fixes #4807

This PR builds on #4956, whose two commits are cherry-picked here; #4956
should be merged first.

The telemetry interceptor and middleware start an `Activity` per icerpc
request, but the activity ended with its status
left `Unset` whatever the outcome: a response with a status code other
than `Ok`, an exception thrown by the invocation
or the dispatch, and a cancellation all looked the same as a successful
call in the exported traces, and no `error.type`
attribute was recorded. Trace backends render `Unset` as success, so
failed RPCs did not show up as errors.

Both components now record the outcome before the activity stops,
following the OpenTelemetry semantic conventions for
RPC spans and the "Recording errors" guidance. The rules differ by span
kind, as they do for HTTP client and server
spans:

- The interceptor (client span) tags every response with
`rpc.status_code`. A status code other than `Ok` sets the
activity status to `Error`, with the response error message as the
status description, and tags `error.type` with
the status code name. An exception sets the activity status to `Error`
with the exception message as the status
description and tags `error.type` with the exception's fully qualified
type name; no status code is recorded since
  there is no response.
- The middleware (server span) tags the activity with the
`rpc.status_code` of the dispatch outcome: the status code of
the returned response or, for an exception thrown by the dispatch, the
status code of the failure response given by
`DispatchException.FromException`. A status code that reports a problem
with the request (`ApplicationError`,
`NotFound`, `InvalidData`, `TruncatedPayload`, `Unauthorized`) leaves
the activity status unset, like a 4xx on an
HTTP server span, whether the dispatch returns it or throws it. Any
other failure status code sets the activity
status to `Error` and tags `error.type` with the stat... (continued)

12894 of 15024 relevant lines covered (85.82%)

2810.92 hits per line

Coverage Regressions

Lines Coverage ∆ File
16
89.49
-0.01% IceRpc/Internal/IceProtocolConnection.cs
5
91.63
0.52% IceRpc/Internal/IceRpcProtocolConnection.cs
5
88.35
-4.85% IceRpc/Internal/PipeReaderExtensions.cs
4
93.44
2.74% IceRpc.Telemetry/TelemetryInterceptor.cs
2
97.4
1.95% IceRpc.Telemetry/TelemetryMiddleware.cs
Jobs
ID Job ID Ran Files Coverage
1 34984905743.1 15 Sep 2026 02:58PM UTC 3799
15.64
GitHub Action Run
Source Files on build 34984905743
  • Tree
  • List 274
  • Changed 205
  • Source Changed 0
  • Coverage Changed 205
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #34984905743
  • 6b43072c on github
  • Prev Build on main (#34983186710)
  • Next Build on main (#35012653639)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc