• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 34983186710
86%

Build:
DEFAULT BRANCH: main
Ran 15 Sep 2026 02:43PM UTC
Jobs 1
Files 272
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Sep 2026 02:40PM UTC coverage: 85.654% (+0.02%) from 85.633%
34983186710

push

github

web-flow
Keep the Slic stream-count permit until the peer consumed the last stream frame (#4958)

A burst of one-way requests on a Slic connection could make the server
abort the connection with "The maximum unidirectional stream count N was
reached", which lost every request still in flight on it. The client's
own stream limit exists to prevent this and was not enforced: the client
released a one-way stream's slot as soon as it had sent the request,
before the server consumed it, so it could open more streams than the
server allows.

The cause is on the sending side of the stream. When the last stream
frame is sent by a write with endStream, as the icerpc protocol
connection does when it copies a request or response payload, completing
the output afterwards closed writes at once, in the branch of
`CloseWrites` that has no frame to send. The stream was released, and
its permit reused, before the peer's `StreamReadsClosed` frame
acknowledged that the data was consumed. When the last frame is sent by
the output completion instead, `CloseWrites` already waits for that
frame before it closes a local stream's writes, so the two paths
disagreed on when a local stream is released.

A unidirectional stream, whose reads are closed at construction, was
released as soon as its output was completed. A bidirectional stream was
released when the response's `StreamLast` frame was read, before the
peer's `StreamReadsClosed` frame; since a server usually consumes the
request before it responds, the count mismatch there needs a server that
responds before it consumed the whole request.

### Fix

The no-frame branch of `CloseWrites` closes writes only for unstarted
streams. A started remote stream reaches it only with writes already
closed. A started local stream that queued its `StreamLast` frame closes
writes when the peer's `StreamReadsClosed` frame is received, as the
`StreamLast` frame written by `CloseWrites` itself already does.

This builds on #4947, now merged: without ... (continued)

12825 of 14973 relevant lines covered (85.65%)

2807.02 hits per line

Coverage Regressions

Lines Coverage ∆ File
9
92.37
0.03% IceRpc/Transports/Slic/Internal/SlicStream.cs
8
89.67
-0.71% IceRpc/Transports/Slic/Internal/SlicConnection.cs
3
81.44
-0.28% IceRpc/ClientConnection.cs
3
91.11
-0.32% IceRpc/Internal/IceRpcProtocolConnection.cs
1
91.95
1.43% IceRpc/Server.cs
Jobs
ID Job ID Ran Files Coverage
1 34983186710.1 15 Sep 2026 02:43PM UTC 3777
15.6
GitHub Action Run
Source Files on build 34983186710
  • Tree
  • List 272
  • Changed 203
  • Source Changed 0
  • Coverage Changed 203
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #34983186710
  • 58b13904 on github
  • Prev Build on main (#34884921330)
  • Next Build on main (#34984905743)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc