• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 35012653639
86%

Build:
DEFAULT BRANCH: main
Ran 15 Sep 2026 07:20PM UTC
Jobs 1
Files 274
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Sep 2026 07:16PM UTC coverage: 85.769% (-0.05%) from 85.823%
35012653639

push

github

web-flow
Sign the first-party dependency copies packed into the Tools packages (#4959)

Fixes #4949

The release workflow signed, for each project under `src`, only the
assembly named after the project in that project's own `bin` folder.
`IceRpc.Protobuf.Tools` and `IceRpc.Slice.Tools` pack the `bin` folders
of their generators and build telemetry plug-ins into `tools/`, and
those folders also hold copy-local copies of other first-party
assemblies. The catalog never listed these copies, so the published
Tools packages shipped them unsigned. The 0.6.0 packages on nuget.org
have 7 of them (`Get-AuthenticodeSignature` reports `NotSigned`):

- `IceRpc.Slice.Tools`: `tools/IceRpc.dll`, `tools/IceRpc.Slice.dll`,
`tools/ZeroC.Slice.Codec.dll`, `tools/ZeroC.Slice.Symbols.dll`
- `IceRpc.Protobuf.Tools`: `tools/IceRpc.dll`,
`tools/IceRpc.Protobuf.dll`, `tools/ZeroC.Slice.Codec.dll`

This PR searches all of `src` for each project's assembly, so every copy
under a `bin/Release/net*` folder is signed where it is. That is the
smaller of the two fixes proposed in the issue, and it also covers any
copies the Tools payloads pick up later. The catalog grows from 24 to 67
files. The 36 new entries that no package includes cost some extra
signatures. For scale, signing took 51s in the 0.6.0 release job, which
finished in 3m20s against a 10-minute timeout.

Verified locally the same way as #4942: after a Release build, I ran
each version of the "Collect Files to Sign" script as written in the
workflow, appended a marker to every catalog file to stand in for
signing, ran `dotnet pack --no-build`, and checked every first-party dll
in the resulting packages:

- before: 23 marked, 7 unmarked (the 7 copies above)
- after: 30 marked, 0 unmarked

The "Collect Files to Sign" step is the same on `0.6.x`, so this commit
cherry-picks cleanly.

## What's Changed entry

None — release packaging fix: the first-party assemblies bundled in the
Tools packages are now signed like the rest of the package.

12886 of 15024 relevant lines covered (85.77%)

2813.56 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
81.72
-1.39% IceRpc/ClientConnection.cs
4
91.59
-0.36% IceRpc/Server.cs
2
90.56
-0.18% IceRpc/Transports/Slic/Internal/SlicConnection.cs
Jobs
ID Job ID Ran Files Coverage
1 35012653639.1 15 Sep 2026 07:20PM UTC 3799
15.6
GitHub Action Run
Source Files on build 35012653639
  • Tree
  • List 274
  • Changed 204
  • Source Changed 0
  • Coverage Changed 204
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #35012653639
  • e4f4d14b on github
  • Prev Build on main (#34984905743)
  • Next Build on main (#35019994454)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc