IJHack / QtPass / 34956435626

68%

main: 93%

push

github

Backport: fix copying an entry onto a folder in the native backend (#1735) (#1748)

* Fix copying an entry onto a folder in the native backend (#1682) (#1735)

* Fix copying an entry onto a folder in the native backend (#1682)

A drag-and-drop copy (Ctrl-drag) of an entry onto a folder hands the
folder path to the backend, the same way a move does; the pass CLI
backend relies on that (`pass cp <name> <folder>`). ImitatePass::Move
resolves that folder into the real target via resolveMoveDestination,
but ImitatePass::Copy passed the folder straight to QFile::copy, which
cannot write a directory, so every copy onto a folder failed with
"Copy failed".

Resolve the destination in Copy with the same resolveMoveDestination
used by Move (into the folder, .gpg appended, no clobbering without
force) and remove/copy/git add/commit/re-encrypt on the resolved path.
A clash that resolveMoveDestination refuses is now reported with the
existing "Copy failed" critical instead of being silently dropped.
StoreModel and RealPass are unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Address review: never let a forced copy onto the entry's own folder delete it

resolveMoveDestination() maps a folder destination that is the source's
own folder to the source path itself; with force, the QFile::remove() that
clears the target then deleted the only copy and QFile::copy() failed.
Refuse that case with the existing "Copy failed" critical. Not reachable
from the drag-and-drop path (the model passes force=false), but Copy() is
public API. Test extends imitatePass_copyOntoExistingEntryClash; it fails
without the guard ('QFile::exists(dst)' returned FALSE).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit c3181acae833a3a4a66b... (continued)

15 of 16 new or added lines in 1 file covered. (93.75%)

5043 of 7386 relevant lines covered (68.28%)

93.05 hits per line