solidjs / solid / 34906776309

72%

main: 89%

push

github

feat(compiler,babel-plugin,solid): componentNames for SSR output; ssrScope swaps the id-bearing owner (#3441)

The SSR generate honours `componentNames` the way `dom` does. Under the
option both compilers keep the `createComponent` call they otherwise inline
to `Comp(props)` and pass the source tag text —
`_$createComponent(Comp, props, "Comp")` — so the server runtime's
observe/dev `createComponent` (a transparent, labelled owner around the
body, #3433) labels every compiled component and a server finding's
`ownerPath` reads `<App> › <Page>` like the client's. Without the option
SSR still inlines: prod output is byte-identical. Universal and dynamic
stay unlabelled. `@solidjs/vite-plugin` already passes the option for its
dev and observe postures for every generate, so app server builds pick this
up with no config change. Oxc's `jsx_tag_name` is now a shared,
closure-based helper so the SSR lowering reuses it (`this.Row` through the
`_self$` pre-pass, member tags). The `ssrInert` fixture becomes `ssr`,
widened to the DOM fixture's shapes; the Oxc suite pins that SSR without
the option imports no `createComponent`.

Compiling the web server suite with the option (vite.config.server.mjs —
the dev posture) surfaced a latent `ssrScope` bug: the virtual hole scope
swapped the CURRENT owner's `id`/`_childCount`, but content inside a hole
resolves ids by walking up past transparent owners, so with one in between
the reserved slot was invisible and the hole's content took fresh ids from
the enclosing counter (`_hk=3` where the client expects `_hk=10`). Reachable
in prod today through `runInServerComponentScope` (transparent), ubiquitous
once every component body runs under a labelled owner. The scope now swaps
the nearest id-bearing owner (solid/test/server/ssr-scope.spec.ts covers a
plain transparent owner, the server-component scope, the labelled
component owner, and nesting).

server-diagnostics.spec.tsx drops its `mount()` workaround for plain JSX;
bound... (continued)

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.09 hits per line