solidjs / solid / 34936052009

72%

main: 89%

push

github

test(signals): visibility oracle — node state × reader kind; latest() of an uninitialized source throws; A7/A16/A17/A32 rulings (#3449)

* test(signals): rules index must be current — --check compares the committed index with a regeneration

The gate verified citations and pins but not that docs/RULES-INDEX.md
itself was regenerated after the docs changed; it could go stale silently.
--check now regenerates in memory and compares with the committed file,
normalized for what prettier does on commit (cell padding, escaped
underscores, blank lines around headings, dash runs).

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(signals): visibility oracle — node state × reader kind → what is served

Ten node states (committed, staged ambient, held by an action, override
active, override ambient, superseded with an initialized / an uninitialized
downstream, pending own async, uninitialized, loading window) × nine reader
kinds (untracked, derives-from, published, pre-existing, stale foreign,
children-forbidden, latest, isPending, authoritative). 90 cells. Each
expected value cites the rule that fixes it; cells the spec does not fix
are pinned as `observed` and listed by the report
(VISIBILITY_ORACLE_REPORT=<file>); cells where the runtime disagrees with
the rule are pinned at current behavior as `violation` so the suite stays
green and the disagreement stays visible — fixing the runtime fails the
cell, which is then flipped to `rule`.

Harness lessons recorded in the file: every open-ended promise is released
between cells (a never-settling action left its transaction live across
the next cell); pre-flush states are built synchronously (an async build
crosses the scheduler's microtask flush); the stale reader lets NotReady
propagate so a suspended pass reads HELD.

Three violations (A18 c/d, A29) and eighteen unspecified cells in the
first run — reported separately.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(signals): latest() of an uninit... (continued)

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.07 hits per line