solidjs / solid / 34905520376

72%

main: 89%

push

github

chore(web): deprecate <Dynamic> in favor of dynamic() (#3437)

* chore(web): deprecate <Dynamic> in favor of dynamic()

<Dynamic component={…}> is the same primitive as dynamic() with a worse
shape. The tag travels in the props bag, so every instance merges `component`
in at the call site, omit()s it back out inside, and builds a fresh dynamic()
factory — with its memo — because a JSX wrapper has nowhere to hoist one.
Polymorphic-component libraries end up omitting `as`, handing the tag to
<Dynamic>, which merges it back in under `component` to omit it again (six
proxy layers per part instance in Kobalte's solid2 branch, two of them this).
dynamic() has none of that for one extra line, and makes the lifetime
explicit — where the memo lives, that the source is a function.

Every other flow component is the same shape as its primitive (Show ↔
createMemo, For ↔ mapArray); Dynamic is the one whose JSX form has a
structural cost no runtime work can remove. Deprecated (JSDoc, no runtime
warning) through the RCs; removed before stable.

Docs: control-flow RFC and MIGRATION updated; tsrx frontend notes record the
follow-up that `<{expr}>` dynamic tags must retarget their lowering from the
Dynamic builtIn to createComponent(dynamic(() => expr), props) in both
compilers before removal.

Co-authored-by: Cursor <cursoragent@cursor.com>

* docs: <Dynamic> is deprecated but kept in 2.0, not removed before stable

The RCs are past public API removals. Drop every 'removed before stable'
claim from the JSDoc, changeset, migration guide, control-flow RFC (moved
from the Removals table into a Deprecated table), and tsrx notes. The
deprecation and the migration guidance stand.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude via Cursor <noreply@cursor.com>

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.07 hits per line