solidjs / solid / 34903359626

72%

main: 89%

push

github

fix(web): dynamic() honors xmlns when creating a tag-name element (#3386) (#3436)

* fix(web): dynamic() honors xmlns when creating a tag-name element (#3386)

The compiler resolves a tag's namespace from its parent at build time; the
dynamic() runtime path creates the element before it has a parent, so a tag
that exists in both HTML and SVG (a, script, style, title) was always an HTML
element — `<svg><Link href/></svg>` with `Link = dynamic(() => "a")` produced
an HTML anchor inside the SVG tree (#3386 part 2).

The instance now says which namespace it means with the attribute compiled
JSX already uses for exactly this (`<a xmlns="http://www.w3.org/2000/svg">`).
Like `is`, `xmlns` is an attribute of the element that also decides how the
node is created: read once, untracked, at creation — the DOM can't
re-namespace a node — then applied through spread() as an ordinary attribute,
so a client-rendered element carries the same attribute the server serializes
and the parser keeps. Server: nothing to do; ssrElement already emits it, and
hydration claims the parser-namespaced node. Without xmlns the namespace is
still inferred from the tag.

Types: dynamic() returns Component<DynamicComponentProps<T>>, adding
`xmlns?: string` for tag-name targets only (the ambiguous tags' intrinsic
attribute types are the HTML ones, which lack it).

Tests: namespaceURI with/without xmlns inside <svg> and <math>, inference
still wins for unambiguous tags, xmlns overrides inference both ways, <Dynamic>
parity, read-once (later values update the attribute, never the node); server
output byte-equal to compiled `<a xmlns>`; parity-harness scenario hydrating a
dynamic() <a xmlns> inside <svg>. Also pins ref arrays through spread into a
dynamic() tag (the shape Kobalte's solid2 branch works around at rc.3) as
working on next.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): accept xmlns on every element's attribute type

CI test-types rejected the compiled-JSX compar... (continued)

519 of 790 branches covered (65.7%)

Branch coverage included in aggregate %.

772 of 1007 relevant lines covered (76.66%)

15.08 hits per line